Check STL usage (invalidation of iterators, mismatching containers, etc) More...

#include <checkstl.h>

Inheritance diagram for CheckStl:

Public Member Functions
	CheckStl ()
	This constructor is used when registering the CheckClass. More...

Public Member Functions inherited from Check
	Check (const std::string &aname)
	This constructor is used when registering the CheckClass. More...

virtual	~Check ()

	Check (const Check &)=delete

Check &	operator= (const Check &)=delete

const std::string &	name () const
	class name, used to generate documentation More...

virtual FileInfo *	getFileInfo (const Tokenizer &, const Settings &) const

virtual FileInfo *	loadFileInfoFromXml (const tinyxml2::XMLElement *xmlElement) const

virtual bool	analyseWholeProgram (const CTU::FileInfo ctu, const std::list< FileInfo > &fileInfo, const Settings &, ErrorLogger &)

Private Types
enum class	SubstrErrorType { EMPTY , COPY , PREFIX , PREFIX_CONCAT }

Private Member Functions
	CheckStl (const Tokenizer tokenizer, const Settings settings, ErrorLogger *errorLogger)
	This constructor is used when running checks. More...

void	runChecks (const Tokenizer &tokenizer, ErrorLogger *errorLogger) override
	run checks, the token list is not simplified More...

void	outOfBounds ()
	Accessing container out of bounds using ValueFlow. More...

void	outOfBoundsIndexExpression ()
	Accessing container out of bounds, following index expression. More...

void	stlOutOfBounds ()
	Finds errors like this: for (unsigned ii = 0; ii <= foo.size(); ++ii) More...

void	negativeIndex ()
	negative index for array like containers More...

void	iterators ()
	Finds errors like this: for (it = foo.begin(); it != bar.end(); ++it) More...

void	invalidContainer ()

bool	checkIteratorPair (const Token tok1, const Token tok2)

void	mismatchingContainers ()
	Mismatching containers: std::find(foo.begin(), bar.end(), x) More...

void	mismatchingContainerIterator ()

void	erase ()
	Dangerous usage of erase. More...

void	eraseCheckLoopVar (const Scope &scope, const Variable *var)

void	stlBoundaries ()
	bad condition. More...

void	if_find ()
	if (a.find(x)) - possibly incorrect condition More...

void	checkFindInsert ()

void	size ()
	Suggest using empty() instead of checking size() against zero for containers. More...

void	redundantCondition ()
	Check for redundant condition 'if (ints.find(1) != ints.end()) ints.remove(123);'. More...

void	missingComparison ()
	Missing inner comparison, when incrementing iterator inside loop Dangers: More...

void	string_c_str ()
	Check for common mistakes when using the function string::c_str() More...

void	uselessCalls ()
	Check calls that using them is useless More...

void	checkDereferenceInvalidIterator ()
	Check for dereferencing an iterator that is invalid More...

void	checkDereferenceInvalidIterator2 ()

void	dereferenceErasedError (const Token erased, const Token deref, const std::string &itername, bool inconclusive)
	Dereferencing an erased iterator. More...

void	useStlAlgorithm ()
	Look for loops that can replaced with std algorithms. More...

void	knownEmptyContainer ()

void	eraseIteratorOutOfBounds ()

void	checkMutexes ()

bool	isContainerSize (const Token containerToken, const Token expr) const

bool	isContainerSizeGE (const Token containerToken, const Token expr) const

void	missingComparisonError (const Token incrementToken1, const Token incrementToken2)

void	string_c_strThrowError (const Token *tok)

void	string_c_strError (const Token *tok)

void	string_c_strReturn (const Token *tok)

void	string_c_strParam (const Token *tok, nonneg int number, const std::string &argtype="std::string")

void	string_c_strConstructor (const Token *tok, const std::string &argtype="std::string")

void	string_c_strAssignment (const Token *tok, const std::string &argtype="std::string")

void	string_c_strConcat (const Token *tok)

void	string_c_strStream (const Token *tok)

void	outOfBoundsError (const Token tok, const std::string &containerName, const ValueFlow::Value containerSize, const std::string &index, const ValueFlow::Value *indexValue)

void	outOfBoundsIndexExpressionError (const Token tok, const Token index)

void	stlOutOfBoundsError (const Token *tok, const std::string &num, const std::string &var, bool at)

void	negativeIndexError (const Token *tok, const ValueFlow::Value &index)

void	invalidIteratorError (const Token *tok, const std::string &iteratorName)

void	iteratorsError (const Token *tok, const std::string &containerName1, const std::string &containerName2)

void	iteratorsError (const Token tok, const Token containerTok, const std::string &containerName1, const std::string &containerName2)

void	iteratorsError (const Token tok, const Token containerTok, const std::string &containerName)

void	mismatchingContainerIteratorError (const Token containerTok, const Token iterTok, const Token *containerTok2)

void	mismatchingContainersError (const Token tok1, const Token tok2)

void	mismatchingContainerExpressionError (const Token tok1, const Token tok2)

void	sameIteratorExpressionError (const Token *tok)

void	stlBoundariesError (const Token *tok)

void	if_findError (const Token *tok, bool str)

void	checkFindInsertError (const Token *tok)

void	sizeError (const Token *tok)

void	redundantIfRemoveError (const Token *tok)

void	invalidContainerLoopError (const Token tok, const Token loopTok, ErrorPath errorPath)

void	invalidContainerError (const Token tok, const Token contTok, const ValueFlow::Value *val, ErrorPath errorPath)

void	invalidContainerReferenceError (const Token tok, const Token contTok, ErrorPath errorPath)

void	uselessCallsReturnValueError (const Token *tok, const std::string &varname, const std::string &function)

void	uselessCallsSwapError (const Token *tok, const std::string &varname)

void	uselessCallsSubstrError (const Token *tok, SubstrErrorType type)

void	uselessCallsEmptyError (const Token *tok)

void	uselessCallsRemoveError (const Token *tok, const std::string &function)

void	uselessCallsConstructorError (const Token *tok)

void	dereferenceInvalidIteratorError (const Token *deref, const std::string &iterName)

void	dereferenceInvalidIteratorError (const Token tok, const ValueFlow::Value value, bool inconclusive)

void	useStlAlgorithmError (const Token *tok, const std::string &algoName)

void	knownEmptyContainerError (const Token *tok, const std::string &algo)

void	eraseIteratorOutOfBoundsError (const Token ftok, const Token itertok, const ValueFlow::Value *val=nullptr)

void	globalLockGuardError (const Token *tok)

void	localMutexError (const Token *tok)

void	getErrorMessages (ErrorLogger errorLogger, const Settings settings) const override
	get error messages More...

std::string	classInfo () const override
	get information about this class, used to generate documentation More...

Static Private Member Functions
static std::string	myName ()

Additional Inherited Members
Static Public Member Functions inherited from Check
static std::list< Check * > &	instances ()
	List of registered check classes. More...

static void	writeToErrorList (const ErrorMessage &errmsg)
	Write given error to stdout in xml format. More...

Protected Member Functions inherited from Check
	Check (std::string aname, const Tokenizer tokenizer, const Settings settings, ErrorLogger *errorLogger)
	This constructor is used when running checks. More...

void	reportError (const Token *tok, const Severity severity, const std::string &id, const std::string &msg)
	report an error More...

void	reportError (const Token *tok, const Severity severity, const std::string &id, const std::string &msg, const CWE &cwe, Certainty certainty)
	report an error More...

void	reportError (const std::list< const Token * > &callstack, Severity severity, const std::string &id, const std::string &msg)
	report an error More...

void	reportError (const std::list< const Token * > &callstack, Severity severity, const std::string &id, const std::string &msg, const CWE &cwe, Certainty certainty)
	report an error More...

void	reportError (const ErrorPath &errorPath, Severity severity, const char id[], const std::string &msg, const CWE &cwe, Certainty certainty)

void	logChecker (const char id[])
	log checker More...

ErrorPath	getErrorPath (const Token errtok, const ValueFlow::Value value, std::string bug) const

bool	wrongData (const Token tok, const char str)
	Use WRONG_DATA in checkers when you check for wrong data. More...

Static Protected Member Functions inherited from Check
static std::string	getMessageId (const ValueFlow::Value &value, const char id[])

Protected Attributes inherited from Check
const Tokenizer *const	mTokenizer {}

const Settings *const	mSettings {}

ErrorLogger *const	mErrorLogger {}

Detailed Description

Check STL usage (invalidation of iterators, mismatching containers, etc)

Definition at line 45 of file checkstl.h.

Member Enumeration Documentation

◆ SubstrErrorType

enum CheckStl::SubstrErrorType

strongprivate

Enumerator
EMPTY
COPY
PREFIX
PREFIX_CONCAT

Definition at line 227 of file checkstl.h.

Constructor & Destructor Documentation

◆ CheckStl() [1/2]

CheckStl::CheckStl ( )

inline

This constructor is used when registering the CheckClass.

Definition at line 48 of file checkstl.h.

◆ CheckStl() [2/2]

CheckStl::CheckStl	(	const Tokenizer *	tokenizer,
		const Settings *	settings,
		ErrorLogger *	errorLogger
	)

inlineprivate

This constructor is used when running checks.

Definition at line 52 of file checkstl.h.

Member Function Documentation

◆ checkDereferenceInvalidIterator()

void CheckStl::checkDereferenceInvalidIterator ( )

private

Check for dereferencing an iterator that is invalid

Definition at line 2352 of file checkstl.cpp.

References Scope::classDef, dereferenceInvalidIteratorError(), Scope::eDo, Scope::eFor, Scope::eIf, Token::findmatch(), Token::findsimplematch(), Tokenizer::getSymbolDatabase(), SimpleEnableGroup< T >::isEnabled(), Scope::isLoopScope(), Token::link(), Check::logChecker(), Check::mSettings, Check::mTokenizer, Token::next(), SymbolDatabase::scopeList, Settings::severity, Token::strAt(), Token::tokAt(), Scope::type, Token::varId(), and warning.

Referenced by runChecks().

◆ checkDereferenceInvalidIterator2()

void CheckStl::checkDereferenceInvalidIterator2 ( )

private

Definition at line 2416 of file checkstl.cpp.

Referenced by runChecks().

◆ checkFindInsert()

void CheckStl::checkFindInsert ( )

private

◆ checkFindInsertError()

void CheckStl::checkFindInsertError ( const Token * tok )

private

Definition at line 1726 of file checkstl.cpp.

References Token::astParent(), Standards::cpp, Standards::CPP11, Standards::CPP17, CWE398, Token::expressionString(), Check::mSettings, normal, performance, Check::reportError(), Token::simpleMatch(), and Settings::standards.

Referenced by checkFindInsert(), and getErrorMessages().

◆ checkIteratorPair()

bool CheckStl::checkIteratorPair	(	const Token *	tok1,
		const Token *	tok2
	)

private

◆ checkMutexes()

void CheckStl::checkMutexes ( )

private

Definition at line 3255 of file checkstl.cpp.

References Variable::declarationId(), SymbolDatabase::functionScopes, Tokenizer::getSymbolDatabase(), globalLockGuardError(), SimpleEnableGroup< T >::isEnabled(), Variable::isGlobal(), isLocalMutex(), isLockGuard(), isMutex(), Variable::isStatic(), localMutexError(), Check::logChecker(), Token::Match(), Check::mSettings, Check::mTokenizer, Token::next(), Token::scope(), Settings::severity, Token::tokAt(), Token::variable(), and warning.

Referenced by runChecks().

◆ classInfo()

std::string CheckStl::classInfo ( ) const

inlineoverrideprivatevirtual

get information about this class, used to generate documentation

Implements Check.

Definition at line 289 of file checkstl.h.

◆ dereferenceErasedError()

void CheckStl::dereferenceErasedError	(	const Token *	erased,
		const Token *	deref,
		const std::string &	itername,
		bool	inconclusive
	)

private

Dereferencing an erased iterator.

Parameters

erased	token where the erase occurs
deref	token where the dereference occurs
itername	iterator name
inconclusive	inconclusive flag

Definition at line 394 of file checkstl.cpp.

References CWE664, error, inconclusive, normal, and Check::reportError().

Referenced by eraseCheckLoopVar(), getErrorMessages(), and iterators().

◆ dereferenceInvalidIteratorError() [1/2]

void CheckStl::dereferenceInvalidIteratorError	(	const Token *	deref,
		const std::string &	iterName
	)

private

Definition at line 2542 of file checkstl.cpp.

References CWE825, normal, Check::reportError(), and warning.

Referenced by checkDereferenceInvalidIterator(), checkDereferenceInvalidIterator2(), and getErrorMessages().

◆ dereferenceInvalidIteratorError() [2/2]

void CheckStl::dereferenceInvalidIteratorError	(	const Token *	tok,
		const ValueFlow::Value *	value,
		bool	inconclusive
	)

private

Definition at line 2513 of file checkstl.cpp.

References ValueFlow::Value::condition, CWE825, ValueFlow::eitherTheConditionIsRedundant(), error, Token::expressionString(), Check::getErrorPath(), inconclusive, Settings::isEnabled(), ValueFlow::Value::isInconclusive(), ValueFlow::Value::isKnown(), Check::mSettings, normal, Check::reportError(), and warning.

◆ erase()

void CheckStl::erase ( )

private

Dangerous usage of erase.

The iterator is invalidated by erase so it is bad to dereference it after the erase.

Definition at line 1379 of file checkstl.cpp.

References Scope::classDef, Scope::eFor, eraseCheckLoopVar(), Scope::eWhile, Tokenizer::getSymbolDatabase(), Token::isName(), Token::linkAt(), Check::logChecker(), Token::Match(), Check::mTokenizer, Token::previous(), SymbolDatabase::scopeList, Token::simpleMatch(), Token::tokAt(), Scope::type, and Token::variable().

Referenced by runChecks().

◆ eraseCheckLoopVar()

void CheckStl::eraseCheckLoopVar	(	const Scope &	scope,
		const Variable *	var
	)

private

Definition at line 1400 of file checkstl.cpp.

References Token::astParent(), Scope::bodyEnd, Scope::bodyStart, Scope::classDef, Variable::declarationId(), dereferenceErasedError(), isIterator(), isVector(), Token::link(), Token::linkAt(), Token::Match(), Variable::nameToken(), Token::next(), Token::simpleMatch(), Token::str(), Token::tokAt(), and Token::varId().

Referenced by erase().

◆ eraseIteratorOutOfBounds()

void CheckStl::eraseIteratorOutOfBounds ( )

private

◆ eraseIteratorOutOfBoundsError()

void CheckStl::eraseIteratorOutOfBoundsError	(	const Token *	ftok,
		const Token *	itertok,
		const ValueFlow::Value *	val = `nullptr`
	)

private

Definition at line 3149 of file checkstl.cpp.

References ValueFlow::Value::condition, CWE628, ValueFlow::eitherTheConditionIsRedundant(), error, Token::expressionString(), ValueFlow::Value::isPossible(), normal, Check::reportError(), Token::str(), and warning.

Referenced by eraseIteratorOutOfBounds(), and getErrorMessages().

◆ getErrorMessages()

void CheckStl::getErrorMessages	(	ErrorLogger *	errorLogger,
		const Settings *	settings
	)		const

inlineoverrideprivatevirtual

get error messages

Implements Check.

Definition at line 245 of file checkstl.h.

References checkFindInsertError(), dereferenceErasedError(), dereferenceInvalidIteratorError(), emptyString, eraseIteratorOutOfBoundsError(), globalLockGuardError(), if_findError(), invalidContainerError(), invalidContainerLoopError(), invalidIteratorError(), iteratorsError(), knownEmptyContainerError(), localMutexError(), mismatchingContainerExpressionError(), mismatchingContainerIteratorError(), mismatchingContainersError(), missingComparisonError(), negativeIndexError(), outOfBoundsError(), redundantIfRemoveError(), sameIteratorExpressionError(), sizeError(), stlBoundariesError(), stlOutOfBoundsError(), string_c_strError(), string_c_strParam(), string_c_strReturn(), string_c_strThrowError(), uselessCallsEmptyError(), uselessCallsRemoveError(), uselessCallsReturnValueError(), uselessCallsSubstrError(), uselessCallsSwapError(), and useStlAlgorithmError().

◆ globalLockGuardError()

void CheckStl::globalLockGuardError ( const Token * tok )

private

Definition at line 3241 of file checkstl.cpp.

References CWE833, normal, Check::reportError(), and warning.

Referenced by checkMutexes(), and getErrorMessages().

◆ if_find()

void CheckStl::if_find ( )

private

if (a.find(x)) - possibly incorrect condition

Definition at line 1498 of file checkstl.cpp.

References Token::astOperand2(), Token::astParent(), Scope::classDef, Library::detectContainer(), Scope::eIf, Scope::eWhile, Library::Container::FIND, Library::Container::FIND_CONST, Token::findsimplematch(), Library::Container::getAction(), Tokenizer::getSymbolDatabase(), Library::Container::getYield(), if_findCompare(), if_findError(), SimpleEnableGroup< T >::isEnabled(), Library::Container::ITERATOR, Settings::library, Token::linkAt(), Check::logChecker(), Token::Match(), Check::mSettings, Check::mTokenizer, Token::next(), Token::nextTemplateArgument(), performance, SymbolDatabase::scopeList, Settings::severity, Token::simpleMatch(), Library::Container::stdStringLike, Token::str(), Token::tokAt(), Scope::type, Library::Container::type_templateArgNo, Token::variable(), and warning.

Referenced by runChecks().

◆ if_findError()

void CheckStl::if_findError	(	const Token *	tok,
		bool	str
	)

private

Definition at line 1575 of file checkstl.cpp.

References Standards::cpp, Standards::CPP20, CWE398, CWE597, Check::mSettings, normal, performance, Check::reportError(), Settings::standards, and warning.

Referenced by getErrorMessages(), and if_find().

◆ invalidContainer()

void CheckStl::invalidContainer ( )

private

◆ invalidContainerError()

void CheckStl::invalidContainerError	(	const Token *	tok,
		const Token *	contTok,
		const ValueFlow::Value *	val,
		ErrorPath	errorPath
	)

private

Definition at line 1229 of file checkstl.cpp.

References CWE664, error, ValueFlow::Value::errorPath, inconclusive, ValueFlow::Value::isInconclusive(), ValueFlow::lifetimeMessage(), normal, and Check::reportError().

Referenced by getErrorMessages(), and invalidContainer().

◆ invalidContainerLoopError()

void CheckStl::invalidContainerLoopError	(	const Token *	tok,
		const Token *	loopTok,
		ErrorPath	errorPath
	)

private

Definition at line 1214 of file checkstl.cpp.

References CWE664, error, normal, Check::reportError(), and Token::str().

Referenced by getErrorMessages(), and invalidContainer().

◆ invalidContainerReferenceError()

void CheckStl::invalidContainerReferenceError	(	const Token *	tok,
		const Token *	contTok,
		ErrorPath	errorPath
	)

private

Definition at line 1239 of file checkstl.cpp.

References CWE664, error, Token::expressionString(), Check::name(), normal, and Check::reportError().

Referenced by invalidContainer().

◆ invalidIteratorError()

void CheckStl::invalidIteratorError	(	const Token *	tok,
		const std::string &	iteratorName
	)

private

Definition at line 358 of file checkstl.cpp.

References CWE664, error, normal, and Check::reportError().

Referenced by getErrorMessages(), and iterators().

◆ isContainerSize()

bool CheckStl::isContainerSize	(	const Token *	containerToken,
		const Token *	expr
	)		const

private

Definition at line 280 of file checkstl.cpp.

References Token::astOperand1(), ValueType::container, Library::Container::getYield(), isSameExpression(), Token::Match(), Check::mSettings, Token::previous(), Token::simpleMatch(), Library::Container::SIZE, Token::str(), and Token::valueType().

Referenced by isContainerSizeGE().

◆ isContainerSizeGE()

bool CheckStl::isContainerSizeGE	(	const Token *	containerToken,
		const Token *	expr
	)		const

private

Definition at line 291 of file checkstl.cpp.

References Token::astOperand1(), Token::astOperand2(), Token::getValueGE(), Token::hasKnownIntValue(), isContainerSize(), Check::mSettings, Token::str(), and Token::values().

Referenced by outOfBoundsIndexExpression().

◆ iterators()

void CheckStl::iterators ( )

private

Finds errors like this: for (it = foo.begin(); it != bar.end(); ++it)

Definition at line 464 of file checkstl.cpp.

References Scope::bodyEnd, Settings::certainty, dereferenceErasedError(), Token::findsimplematch(), getContainerName(), Tokenizer::getSymbolDatabase(), inconclusive, invalidIteratorError(), SimpleEnableGroup< T >::isEnabled(), isIterator(), isVector(), iteratorsError(), Token::link(), Token::linkAt(), Check::logChecker(), Token::Match(), Check::mSettings, Check::mTokenizer, Token::next(), Token::nextArgument(), Token::previous(), Token::scope(), Token::simpleMatch(), skipMembers(), Token::str(), Token::strAt(), Token::tokAt(), Variable::typeStartToken(), Token::variable(), SymbolDatabase::variableList(), and Token::varId().

Referenced by runChecks().

◆ iteratorsError() [1/3]

void CheckStl::iteratorsError	(	const Token *	tok,
		const std::string &	containerName1,
		const std::string &	containerName2
	)

private

Definition at line 363 of file checkstl.cpp.

References CWE664, error, normal, and Check::reportError().

Referenced by checkIteratorPair(), getErrorMessages(), and iterators().

◆ iteratorsError() [2/3]

void CheckStl::iteratorsError	(	const Token *	tok,
		const Token *	containerTok,
		const std::string &	containerName
	)

private

Definition at line 380 of file checkstl.cpp.

References CWE664, error, normal, and Check::reportError().

◆ iteratorsError() [3/3]

void CheckStl::iteratorsError	(	const Token *	tok,
		const Token *	containerTok,
		const std::string &	containerName1,
		const std::string &	containerName2
	)

private

Definition at line 371 of file checkstl.cpp.

References CWE664, error, normal, and Check::reportError().

◆ knownEmptyContainer()

void CheckStl::knownEmptyContainer ( )

private

◆ knownEmptyContainerError()

void CheckStl::knownEmptyContainerError	(	const Token *	tok,
		const std::string &	algo
	)

private

Definition at line 3075 of file checkstl.cpp.

References astIsIterator(), CWE398, Token::expressionString(), normal, Check::reportError(), and style.

Referenced by getErrorMessages(), and knownEmptyContainer().

◆ localMutexError()

void CheckStl::localMutexError ( const Token * tok )

private

Definition at line 3248 of file checkstl.cpp.

References CWE667, normal, Check::reportError(), and warning.

Referenced by checkMutexes(), and getErrorMessages().

◆ mismatchingContainerExpressionError()

void CheckStl::mismatchingContainerExpressionError	(	const Token *	tok1,
		const Token *	tok2
	)

private

Definition at line 675 of file checkstl.cpp.

References CWE664, Token::expressionString(), normal, Check::reportError(), and warning.

Referenced by checkIteratorPair(), and getErrorMessages().

◆ mismatchingContainerIterator()

void CheckStl::mismatchingContainerIterator ( )

private

◆ mismatchingContainerIteratorError()

void CheckStl::mismatchingContainerIteratorError	(	const Token *	containerTok,
		const Token *	iterTok,
		const Token *	containerTok2
	)

private

Definition at line 649 of file checkstl.cpp.

References CWE664, error, Token::expressionString(), normal, and Check::reportError().

Referenced by getErrorMessages(), and mismatchingContainerIterator().

◆ mismatchingContainers()

void CheckStl::mismatchingContainers ( )

private

Mismatching containers: std::find(foo.begin(), bar.end(), x)

Definition at line 795 of file checkstl.cpp.

References Scope::bodyEnd, Scope::bodyStart, checkIteratorPair(), Library::ArgumentChecks::IteratorInfo::container, SymbolDatabase::functionScopes, Library::getArgIteratorInfo(), getArguments(), Tokenizer::getSymbolDatabase(), isSameExpression(), Settings::library, Check::logChecker(), Token::Match(), mismatchingContainersError(), Check::mSettings, Check::mTokenizer, Token::next(), sameIteratorExpressionError(), and SymbolDatabase::variableList().

Referenced by runChecks().

◆ mismatchingContainersError()

void CheckStl::mismatchingContainersError	(	const Token *	tok1,
		const Token *	tok2
	)

private

Definition at line 663 of file checkstl.cpp.

References CWE664, error, Token::expressionString(), normal, and Check::reportError().

Referenced by checkIteratorPair(), getErrorMessages(), and mismatchingContainers().

◆ missingComparison()

void CheckStl::missingComparison ( )

private

Missing inner comparison, when incrementing iterator inside loop Dangers:

may increment iterator beyond end
may unintentionally skip elements in list/set etc

Definition at line 1860 of file checkstl.cpp.

References Token::astParent(), Scope::bodyEnd, Scope::bodyStart, Scope::classDef, Scope::eFor, Tokenizer::getSymbolDatabase(), SimpleEnableGroup< T >::isEnabled(), Token::linkAt(), Check::logChecker(), Token::Match(), missingComparisonError(), Check::mSettings, Check::mTokenizer, Token::next(), SymbolDatabase::scopeList, Settings::severity, Token::simpleMatch(), Token::tokAt(), Scope::type, and warning.

Referenced by runChecks().

◆ missingComparisonError()

void CheckStl::missingComparisonError	(	const Token *	incrementToken1,
		const Token *	incrementToken2
	)

private

Definition at line 1924 of file checkstl.cpp.

References CWE834, Token::linenr(), normal, Check::reportError(), and warning.

Referenced by getErrorMessages(), and missingComparison().

◆ myName()

static std::string CheckStl::myName ( )

inlinestaticprivate

Definition at line 285 of file checkstl.h.

◆ negativeIndex()

void CheckStl::negativeIndex ( )

private

negative index for array like containers

Definition at line 1341 of file checkstl.cpp.

References Library::Container::arrayLike_indexOp, Token::astOperand2(), Scope::bodyEnd, Scope::bodyStart, Library::detectContainer(), SymbolDatabase::functionScopes, Tokenizer::getSymbolDatabase(), Settings::library, Check::logChecker(), Token::Match(), Check::mSettings, Check::mTokenizer, Variable::nameToken(), negativeIndexError(), Token::next(), Variable::typeStartToken(), and Token::variable().

Referenced by runChecks().

◆ negativeIndexError()

void CheckStl::negativeIndexError	(	const Token *	tok,
		const ValueFlow::Value &	index
	)

private

Definition at line 1365 of file checkstl.cpp.

References ValueFlow::Value::condition, CWE786, ValueFlow::eitherTheConditionIsRedundant(), error, ValueFlow::Value::errorSeverity(), Check::getErrorPath(), inconclusive, ValueFlow::Value::intvalue, ValueFlow::Value::isInconclusive(), ValueFlow::Value::isKnown(), normal, Check::reportError(), and warning.

Referenced by getErrorMessages(), and negativeIndex().

◆ outOfBounds()

void CheckStl::outOfBounds ( )

private

Accessing container out of bounds using ValueFlow.

Definition at line 133 of file checkstl.cpp.

References astIsIterator(), Token::astParent(), astParentSkipParens(), Settings::certainty, containerAppendsElement(), containerPopsElement(), containerYieldsElement(), Token::expressionString(), ValueFlow::findValue(), SymbolDatabase::functionScopes, getContainerIndex(), getLibraryContainer(), Tokenizer::getSymbolDatabase(), Token::hasKnownIntValue(), Token::hasKnownValue(), inconclusive, SimpleEnableGroup< T >::isEnabled(), ValueFlow::isOutOfBounds(), Check::logChecker(), Check::mSettings, Check::mTokenizer, Token::next(), outOfBoundsError(), Settings::severity, Token::simpleMatch(), Library::Container::stdAssociativeLike, Token::values(), and warning.

Referenced by runChecks().

◆ outOfBoundsError()

void CheckStl::outOfBoundsError	(	const Token *	tok,
		const std::string &	containerName,
		const ValueFlow::Value *	containerSize,
		const std::string &	index,
		const ValueFlow::Value *	indexValue
	)